[DirectX] Use "texture" not "SRV" when pretty printing resources #130230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're printing "SRV" here when DXC would print "texture". Fix this to be consistent. Fixes llvm#130227.
|
@llvm/pr-subscribers-backend-directx Author: Justin Bogner (bogner) ChangesWe're printing "SRV" here when DXC would print "texture". Fix this to be consistent. Fixes #130227. Full diff: https://github.com/llvm/llvm-project/pull/130230.diff 3 Files Affected:
diff --git a/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp b/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp
index 7255a9be06d51..83ec574bb5870 100644
--- a/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp
+++ b/llvm/lib/Target/DirectX/DXILPrettyPrinter.cpp
@@ -23,7 +23,7 @@ using namespace llvm;
static StringRef getRCName(dxil::ResourceClass RC) {
switch (RC) {
case dxil::ResourceClass::SRV:
- return "SRV";
+ return "texture";
case dxil::ResourceClass::UAV:
return "UAV";
case dxil::ResourceClass::CBuffer:
diff --git a/llvm/test/CodeGen/DirectX/CreateHandle.ll b/llvm/test/CodeGen/DirectX/CreateHandle.ll
index c4e02fb02733d..048e57c091142 100644
--- a/llvm/test/CodeGen/DirectX/CreateHandle.ll
+++ b/llvm/test/CodeGen/DirectX/CreateHandle.ll
@@ -3,10 +3,10 @@
; CHECK-PRETTY: Type Format Dim ID HLSL Bind Count
; CHECK-PRETTY: ---------- ------- ----------- ------- -------------- ---------
-; CHECK-PRETTY: SRV f32 buf T0 t7 unbounded
-; CHECK-PRETTY: SRV byte r/o T1 t8,space1 1
-; CHECK-PRETTY: SRV struct r/o T2 t2,space4 1
-; CHECK-PRETTY: SRV u32 buf T3 t3,space5 24
+; CHECK-PRETTY: texture f32 buf T0 t7 unbounded
+; CHECK-PRETTY: texture byte r/o T1 t8,space1 1
+; CHECK-PRETTY: texture struct r/o T2 t2,space4 1
+; CHECK-PRETTY: texture u32 buf T3 t3,space5 24
; CHECK-PRETTY: UAV i32 buf U0 u7,space2 1
; CHECK-PRETTY: UAV f32 buf U1 u5,space3 1
diff --git a/llvm/test/CodeGen/DirectX/CreateHandleFromBinding.ll b/llvm/test/CodeGen/DirectX/CreateHandleFromBinding.ll
index 9919a3f2dbd25..089b6eaa563ca 100644
--- a/llvm/test/CodeGen/DirectX/CreateHandleFromBinding.ll
+++ b/llvm/test/CodeGen/DirectX/CreateHandleFromBinding.ll
@@ -3,10 +3,10 @@
; CHECK-PRETTY: Type Format Dim ID HLSL Bind Count
; CHECK-PRETTY: ---------- ------- ----------- ------- -------------- ---------
-; CHECK-PRETTY: SRV f32 buf T0 t7 unbounded
-; CHECK-PRETTY: SRV byte r/o T1 t8,space1 1
-; CHECK-PRETTY: SRV struct r/o T2 t2,space4 1
-; CHECK-PRETTY: SRV u32 buf T3 t3,space5 24
+; CHECK-PRETTY: texture f32 buf T0 t7 unbounded
+; CHECK-PRETTY: texture byte r/o T1 t8,space1 1
+; CHECK-PRETTY: texture struct r/o T2 t2,space4 1
+; CHECK-PRETTY: texture u32 buf T3 t3,space5 24
; CHECK-PRETTY: UAV i32 buf U0 u7,space2 1
; CHECK-PRETTY: UAV f32 buf U1 u5,space3 1
; CHECK-PRETTY: cbuffer NA NA CB0 cb0 1
|
bogner
added a commit
that referenced
this pull request
Mar 13, 2025
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
…m#130230) We're printing "SRV" here when DXC would print "texture". Fix this to be consistent. Fixes llvm#130227.
frederik-h
pushed a commit
to frederik-h/llvm-project
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're printing "SRV" here when DXC would print "texture". Fix this to be consistent.
Fixes #130227.